Added Unity assembly definitions

[JasperCiti]

For more info why it is useful see https://docs.unity3d.com/Manual/ScriptCompilationAssemblyDefinitionFiles.html

Discord username: @JasperCiti#405

[phalasz]

The main issue with asmdefs is that Forge uses a lot of partial classes. So in case someone wants to add a new partial class to add more functionality to one of the Forge classes then they will have to add the file into the forge directory as those files will need to be compiled into the same assembly.

Also Forge works fine with Unity 2019, hence the title of the PR is a bit missleading.

[JasperCiti]

That's too bad. I have try to move the generated stuff outside the assembly, but then the Chat module break. Will have to refactor the Chat module first or something...

[phalasz]

It's not just the generated folder though, but any other partial class. As the other part of some of the generated folder's partial classes are in the main source files in Scripts/Networking.

[JasperCiti]

But if you have code inside one of your own assemblies that depend on FNR, how do you reference that?

[phalasz]

You can reference them by adding FNR as a dependency to your assembly. The main issue is if you want to add further functionality to a partial class, as that would need to be done in the FNR directories so it gets added to the FNR assembly.

c# docs:

All partial-type definitions meant to be parts of the same type must be defined in 
the same assembly and the same module (.exe or .dll file). Partial definitions cannot 
span multiple modules.

[phalasz]

One option could be is to move Assets/Bearded Man Studios Inc/ForgeNetworkingRemaster.asmdef into Assets/Bearded Man Studios Inc/Scripts/Networking/ as that folder should not have any partial classes and used to be compiled into a dll in the past.

[BrentFarris]

I have merged a big cleanup branch and so you will probably need to merge current develop into your fork and resolve conflicts, sorry about this. The main breaking change in develop is the folder paths have updated their names to not have spaces. Please see this commit for more info on the changes

[Crazy8ball]

Requesting changes per comment above.

[phalasz]

Closing this as there have been no movement on it for a long time.