Tab/single user #24
Merged
Tab/single user #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and rear sides of the strip.
… 20 Bytes for the nrf52).
Changed TrafficMode "sig_" param. naming for "traffic_".
Beardmix
reviewed
Aug 9, 2018
| @@ -34,10 +43,14 @@ class EEPROM_Handler | |||
| { | |||
| } | |||
|
|
|||
| void static load(Settings &settings) | |||
| void configure(void) | |||
There was a problem hiding this comment.
This function should also be static, right?
There was a problem hiding this comment.
Could be yes, will set it static.
| @@ -4,14 +4,10 @@ | |||
| #include "ble_handler.h" | |||
| #include "eeprom_handler.h" | |||
|
|
|||
| /* Need to undefine min and max in order to compile <String>. */ | |||
| #undef max | |||
There was a problem hiding this comment.
Why is this not needed any more?
There was a problem hiding this comment.
There was a namesapce conflict between libraries. I replaced the calls by constrain() and std::max() where needed.
| // Front. | ||
| for (int i = std::max(this->p_settings->traffic_front_lower - 1, 0U); i < this->p_settings->traffic_front_upper; ++i) | ||
| { | ||
| strip.setPixelColor(i, strip.Color(255, 255, 255)); |
There was a problem hiding this comment.
A light yellow would be better. Pure white is generally too strong and aggressive, even at lower brightness settings.
There was a problem hiding this comment.
Agreed, will be changed later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issues: #1 and #20
Implemented as following:
note: the lightninh direction is part of the issue #19