-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab/single user #24
Tab/single user #24
Conversation
…and rear sides of the strip.
… 20 Bytes for the nrf52).
Changed TrafficMode "sig_" param. naming for "traffic_".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good and cleaner code than before!
Well done :D
@@ -34,10 +43,14 @@ class EEPROM_Handler | |||
{ | |||
} | |||
|
|||
void static load(Settings &settings) | |||
void configure(void) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should also be static, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be yes, will set it static.
@@ -4,14 +4,10 @@ | |||
#include "ble_handler.h" | |||
#include "eeprom_handler.h" | |||
|
|||
/* Need to undefine min and max in order to compile <String>. */ | |||
#undef max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not needed any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a namesapce conflict between libraries. I replaced the calls by constrain() and std::max() where needed.
// Front. | ||
for (int i = std::max(this->p_settings->traffic_front_lower - 1, 0U); i < this->p_settings->traffic_front_upper; ++i) | ||
{ | ||
strip.setPixelColor(i, strip.Color(255, 255, 255)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A light yellow would be better. Pure white is generally too strong and aggressive, even at lower brightness settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, will be changed later.
Fixing issues: #1 and #20
Implemented as following:
note: the lightninh direction is part of the issue #19