Skip to content

Commit

Permalink
fix: use parent from the location not from the datatype (#184)
Browse files Browse the repository at this point in the history 
* fix: use parent from the location not from the datatype

* fix: fix parent report

* chore: enable test for http
  • Loading branch information
@cfabianski
cfabianski committed Dec 1, 2022
1 parent 82867a0 commit d279ec7
Show file tree
Hide file tree
Showing 10 changed files with 194 additions and 143 deletions.
14 changes: 6 additions & 8 deletions integration/custom_detectors/.snapshots/TestCustomDetectors-detect_rails_jwt
View file
Original file line number Diff line number Diff line change
@@ -1,20 +1,12 @@
data_types:
- name: Email Address
detectors:
- name: detect_rails_jwt
locations:
- filename: testdata/ruby/detect_rails_jwt.rb
line_number: 12
- name: ruby
locations:
- filename: testdata/ruby/detect_rails_jwt.rb
line_number: 12
- name: Physical Address
detectors:
- name: detect_rails_jwt
locations:
- filename: testdata/ruby/detect_rails_jwt.rb
line_number: 10
- name: ruby
locations:
- filename: testdata/ruby/detect_rails_jwt.rb
Expand All @@ -27,11 +19,17 @@ risks:
locations:
- filename: testdata/ruby/detect_rails_jwt.rb
line_number: 12
parent:
line_number: 12
content: JWT.encode(user.email, nil, "none")
- name: Physical Address
stored: false
locations:
- filename: testdata/ruby/detect_rails_jwt.rb
line_number: 10
parent:
line_number: 12
content: JWT.encode(user.email, nil, "none")
components: []


Expand Down
7 changes: 3 additions & 4 deletions integration/custom_detectors/.snapshots/TestCustomDetectors-detect_rails_session
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
data_types:
- name: Email Address
detectors:
- name: detect_rails_session
locations:
- filename: testdata/ruby/detect_rails_session.rb
line_number: 2
- name: ruby
locations:
- filename: testdata/ruby/detect_rails_session.rb
Expand All @@ -23,6 +19,9 @@ risks:
locations:
- filename: testdata/ruby/detect_rails_session.rb
line_number: 2
parent:
line_number: 2
content: session[:current_user] = user.email
components: []


Expand Down
24 changes: 16 additions & 8 deletions integration/custom_detectors/.snapshots/TestCustomDetectors-detect_ruby_logger
View file
Original file line number Diff line number Diff line change
@@ -1,20 +1,12 @@
data_types:
- name: Email Address
detectors:
- name: detect_ruby_logger
locations:
- filename: testdata/ruby/detect_ruby_logger.rb
line_number: 3
- name: ruby
locations:
- filename: testdata/ruby/detect_ruby_logger.rb
line_number: 3
- name: Physical Address
detectors:
- name: detect_ruby_logger
locations:
- filename: testdata/ruby/detect_ruby_logger.rb
line_number: 4
- name: ruby
locations:
- filename: testdata/ruby/detect_ruby_logger.rb
Expand All @@ -27,11 +19,27 @@ risks:
locations:
- filename: testdata/ruby/detect_ruby_logger.rb
line_number: 3
parent:
line_number: 1
content: |-
logger.info(
"user info are:",
user.email,
user.address
)
- name: Physical Address
stored: false
locations:
- filename: testdata/ruby/detect_ruby_logger.rb
line_number: 4
parent:
line_number: 1
content: |-
logger.info(
"user info are:",
user.email,
user.address
)
components: []


Expand Down
86 changes: 66 additions & 20 deletions integration/custom_detectors/.snapshots/TestCustomDetectors-ruby_file_detection
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,6 @@ data_types:
line_number: 12
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 16
- name: ruby_file_detection
locations:
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 5
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 12
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 16
- name: Emails
detectors:
- name: ruby
Expand All @@ -31,12 +23,6 @@ data_types:
line_number: 6
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 16
- name: ruby_file_detection
locations:
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 6
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 16
- name: Lastname
detectors:
- name: ruby
Expand All @@ -45,12 +31,6 @@ data_types:
line_number: 7
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 16
- name: ruby_file_detection
locations:
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 7
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 16
risks:
- detector_id: ruby_file_detection
data_types:
Expand All @@ -59,24 +39,90 @@ risks:
locations:
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 5
parent:
line_number: 1
content: |-
CSV.open("path/to/user.csv", "wb") do |csv|
csv << ["email", "first_name", "last_name"]
users.each do |user|
csv << [
user.email,
user.first_name,
user.last_name
]
end
end
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 12
parent:
line_number: 12
content: 'File.open("users.log", "w") { |f| f.write "#{Time.now} - User #{user.email} logged in\n" }'
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 16
parent:
line_number: 14
content: |-
File.open(user.emails, "users.csv", "w") do |f|
users.each do |user|
f.write "#{user.email},#{user.first_name},#{user.last_name}"
end
end
- name: Firstname
stored: false
locations:
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 6
parent:
line_number: 1
content: |-
CSV.open("path/to/user.csv", "wb") do |csv|
csv << ["email", "first_name", "last_name"]
users.each do |user|
csv << [
user.email,
user.first_name,
user.last_name
]
end
end
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 16
parent:
line_number: 14
content: |-
File.open(user.emails, "users.csv", "w") do |f|
users.each do |user|
f.write "#{user.email},#{user.first_name},#{user.last_name}"
end
end
- name: Lastname
stored: false
locations:
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 7
parent:
line_number: 1
content: |-
CSV.open("path/to/user.csv", "wb") do |csv|
csv << ["email", "first_name", "last_name"]
users.each do |user|
csv << [
user.email,
user.first_name,
user.last_name
]
end
end
- filename: testdata/ruby/ruby_file_detection.rb
line_number: 16
parent:
line_number: 14
content: |-
File.open(user.emails, "users.csv", "w") do |f|
users.each do |user|
f.write "#{user.email},#{user.first_name},#{user.last_name}"
end
end
components: []


Expand Down
Loading

0 comments on commit d279ec7

Please sign in to comment.