Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use parent from the location not from the datatype #184

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

cfabianski
Copy link
Collaborator

@cfabianski cfabianski commented Dec 1, 2022

Description

We were using only 1 context per custom detection / datatype while the context should be at the location level

Also removing the datatype detection in the risk as they would basically be duplicated

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@swarmia
Copy link

swarmia bot commented Dec 1, 2022

Copy link
Contributor

@elsapet elsapet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@elsapet
Copy link
Contributor

elsapet commented Dec 1, 2022

@spdawson FYI once this PR is merged, we should be able to get the code extract (i.e. parent context) for the SMTP risks :)

@elsapet elsapet mentioned this pull request Dec 1, 2022
4 tasks
@cfabianski cfabianski merged commit d279ec7 into main Dec 1, 2022
@cfabianski cfabianski deleted the AMA-3300/bad-context branch December 1, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants