Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve testing for rules #1404

Merged
merged 4 commits into from
Nov 21, 2023
Merged

feat: improve testing for rules #1404

merged 4 commits into from
Nov 21, 2023

Conversation

cfabianski
Copy link
Collaborator

@cfabianski cfabianski commented Nov 17, 2023 •
edited
Loading

Description

Closes #1405

The idea is to allow comments to flag that a finding is expected.
That way we can improve the way we tests

See Bearer/bearer-rules#180

ToDo:

  • Should we use a feature flag to turn this feature on as it might have some perf implication?

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@cfabianski cfabianski mentioned this pull request Nov 17, 2023
Merged
3 tasks
@cfabianski cfabianski changed the title spike: improve testing for rules feat: improve testing for rules Nov 17, 2023
didroe
didroe approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@didroe didroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cfabianski cfabianski force-pushed the spike/improve-testing-for-rules branch from 7a8f040 to 933cae4 Compare November 21, 2023 13:31
@cfabianski cfabianski marked this pull request as ready for review November 21, 2023 13:31
@cfabianski cfabianski force-pushed the spike/improve-testing-for-rules branch from 933cae4 to 4a44b8f Compare November 21, 2023 13:31
@cfabianski cfabianski merged commit b1352b3 into main Nov 21, 2023
7 checks passed
@cfabianski cfabianski deleted the spike/improve-testing-for-rules branch November 21, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didroe didroe didroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve testing for rules
2 participants
@cfabianski @didroe