Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gitlab): simplify diff scan config #1447

Merged
merged 1 commit into from
Jan 5, 2024
Merged

feat(gitlab): simplify diff scan config #1447

merged 1 commit into from
Jan 5, 2024

Conversation

gotbadger
Copy link
Contributor

@gotbadger gotbadger commented Dec 22, 2023 •
edited

Description

  • Try and configure mr number automatically based on available env vars
  • Refactor env var loading of pr number so it comes via flags system

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@gotbadger gotbadger force-pushed the feat/auto-configure-pr-number-in-gitlab branch 2 times, most recently from bf60790 to 94b594c Compare December 22, 2023 11:38
@gotbadger gotbadger force-pushed the feat/auto-configure-pr-number-in-gitlab branch from 94b594c to 7656596 Compare December 22, 2023 13:14
@gotbadger gotbadger merged commit df02552 into main Jan 5, 2024
8 checks passed
@gotbadger gotbadger deleted the feat/auto-configure-pr-number-in-gitlab branch January 5, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gotbadger @cfabianski