-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add UUIDs to recipes and include these in the report #148
feat: Add UUIDs to recipes and include these in the report #148
Conversation
✅ Linked to AMA-3176 · Add UUIDs to Recipes and include these in the Report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I wonder if we want to the recipe name as well as recipe UUID in the report. @cfabianski any thoughts on this?
You are on the right track @elsapet |
2cb881a
to
8a0ad5a
Compare
The UUIDs are copied from the recipe data in the Bearer API management application.
8a0ad5a
to
83060c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Relying on the recipe name is fragile; switch to use the recipe UUID, and output this in reports for internal consumption.
Detectors report
Before
After
The
recipe_uuid
attribute is present:Dataflow report
Before
After
Same as before (no change).
Checklist