Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include classified frameworks in dataflow report #153

Merged

Conversation

spdawson
Copy link
Contributor

Sample dataflow YAML Output before:

datatypes:
    - name: Email Address
      detectors:
        - name: ruby
          locations:
            - filename: config/initializers/devise.rb
              linenumber: 186
risks: []
components:
    - name: postgresql
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 151
    - name: aws s3
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 81
    - name: redis
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 191
    - name: aws key management service (kms)
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 78

Sample dataflow YAML output after:

datatypes:
    - name: Email Address
      detectors:
        - name: ruby
          locations:
            - filename: config/initializers/devise.rb
              linenumber: 186
risks: []
components:
    - name: disk
      locations:
        - detector: rails
          filename: config/storage.yml
          linenumber: 5
    - name: postgresql
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 151
        - detector: rails
          filename: config/database.yml
          linenumber: 85
    - name: aws s3
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 81
        - detector: rails
          filename: config/storage.yml
          linenumber: 16
    - name: redis
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 191
        - detector: rails
          filename: config/environments/production.rb
          linenumber: 57
    - name: aws key management service (kms)
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 78

Description

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@swarmia
Copy link

swarmia bot commented Nov 22, 2022

Sample dataflow YAML Output before:

```yaml
datatypes:
    - name: Email Address
      detectors:
        - name: ruby
          locations:
            - filename: config/initializers/devise.rb
              linenumber: 186
risks: []
components:
    - name: postgresql
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 151
    - name: aws s3
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 81
    - name: redis
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 191
    - name: aws key management service (kms)
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 78
```

Sample dataflow YAML output after:

```yaml
datatypes:
    - name: Email Address
      detectors:
        - name: ruby
          locations:
            - filename: config/initializers/devise.rb
              linenumber: 186
risks: []
components:
    - name: disk
      locations:
        - detector: rails
          filename: config/storage.yml
          linenumber: 5
    - name: postgresql
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 151
        - detector: rails
          filename: config/database.yml
          linenumber: 85
    - name: aws s3
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 81
        - detector: rails
          filename: config/storage.yml
          linenumber: 16
    - name: redis
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 191
        - detector: rails
          filename: config/environments/production.rb
          linenumber: 57
    - name: aws key management service (kms)
      locations:
        - detector: gemfile-lock
          filename: Gemfile.lock
          linenumber: 78
```
@spdawson spdawson force-pushed the AMA-3229-include-classified-frameworks-in-dataflow-report branch from 8ea38eb to 7e7c76b Compare November 22, 2022 12:12
@spdawson spdawson merged commit 6a9e591 into main Nov 22, 2022
@spdawson spdawson deleted the AMA-3229-include-classified-frameworks-in-dataflow-report branch November 22, 2022 13:35
cfabianski added a commit that referenced this pull request Nov 22, 2022
…w-report

* origin/main:
  feat: Include classified frameworks in dataflow report (#153)
  feat: Add UUIDs to recipes and include these in the report (#148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants