feat: some config fields are not loading #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to AMA-3303 · Some config fields are not loading |
vjerci
added
bug
…com:bearer/curio into AMA-3303-some-config-fields-are-not-loading
vjerci
requested review from
cfabianski,
elsapet and
spdawson
and removed request for
cfabianski and
elsapet
cfabianski
reviewed
Dec 2, 2022
cfabianski
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes bug where we weren't using config from file when file was specified.
Viper is actually using mapstructure lib behind the scenes, which means we need to add mapstructure metatags for settings being loaded from file
Checklist