Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(classification): classify known object schema detections #85

Merged
merged 6 commits into from
Oct 28, 2022

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Oct 26, 2022

Description

  • Add classification for "known person object" schema detections (top row of this Miro)
  • Ensure all data type classification files are added (friendly name is not unique so we include ID when building filename)
  • Some simplification of classify methods (remove detector type checks and cloud related things)

Note: we're assuming only 1 "layer" of data type nesting (e.g. User object with Name field and not User object with Address object with Postcode field)

Some TODOs / open questions (see comments)

Things to handle in later PRs:

  • Context check (see Miro - example, Health context)
  • Handling further nesting (e.g. User -> Address -> Postcode example)
  • The other branches in the Miro (Unknown Objects, etc)

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@swarmia
Copy link

swarmia bot commented Oct 26, 2022

@elsapet elsapet force-pushed the AMA-3026-classify-schema-detections-not-nested branch from 780dab8 to 2b05507 Compare October 27, 2022 10:44
@elsapet elsapet marked this pull request as ready for review October 27, 2022 10:53
@elsapet elsapet force-pushed the AMA-3026-classify-schema-detections-not-nested branch from 2b05507 to 4fd9128 Compare October 27, 2022 12:51
Copy link
Collaborator

@cfabianski cfabianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems correct to me! Good job

@elsapet elsapet merged commit 00a3271 into main Oct 28, 2022
@elsapet elsapet deleted the AMA-3026-classify-schema-detections-not-nested branch October 28, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants