Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple External Modules #8

Closed
Ethan-DeBandi99 opened this issue Mar 30, 2022 · 1 comment · Fixed by #25
Closed

Multiple External Modules #8

Ethan-DeBandi99 opened this issue Mar 30, 2022 · 1 comment · Fixed by #25
Assignees
@Ethan-DeBandi99
Labels
enhancement New feature or request In Progress Issue is currently being worked.

Comments

@Ethan-DeBandi99
Copy link
Contributor

The module_configuration.py defined in PR #6 and PR #7, will install a single module. Once these are merged, we will need to update module_configuration.py to take in multiple modules and configure them all.
@Ethan-DeBandi99 Ethan-DeBandi99 added the enhancement New feature or request label Mar 30, 2022
@Ethan-DeBandi99 Ethan-DeBandi99 self-assigned this Mar 30, 2022
@Ethan-DeBandi99 Ethan-DeBandi99 mentioned this issue Apr 15, 2022
Merged
@Ethan-DeBandi99
Copy link
Contributor Author

For this issue, it would probably be beneficial to allow a user to supply a list of package locations via:

  • text or json file.
  • Argument for call to module_configuration.py
  • Use the packages in a specified parent directory.

Each of these would require their own argument to ease parsing requirements.

@Ethan-DeBandi99 Ethan-DeBandi99 added the In Progress Issue is currently being worked. label Apr 18, 2022
@Ethan-DeBandi99 Ethan-DeBandi99 mentioned this issue Apr 19, 2022
Merged
mhmerrill added a commit that referenced this issue Apr 28, 2022
@Ethan-DeBandi99 @mhmerrill
Closes #8 - Multiple External Modules (#25)
3bd89a2 
* Configuration updated to allow multiple modules to be configured/installed at once.

* File cleanup. Added DocStrings.

* Adding new arguments to install.md and updating so it does not limit to single pkg install.

Co-authored-by: Michael Merrill <48804335+mhmerrill@users.noreply.github.com>
@Ethan-DeBandi99 Ethan-DeBandi99 mentioned this issue May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ethan-DeBandi99 Ethan-DeBandi99

Labels
enhancement New feature or request In Progress Issue is currently being worked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #8 - Multiple External Modules Ethan-DeBandi99/arkouda-contrib
1 participant
@Ethan-DeBandi99