Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataframe Registration with segarrays #2380

Closed
21771 opened this issue Apr 14, 2023 · 0 comments · Fixed by #2392
Closed

Dataframe Registration with segarrays #2380

21771 opened this issue Apr 14, 2023 · 0 comments · Fixed by #2392
Assignees
@stress-tess
Labels
bug Something isn't working User Reported A user submitted the issue

Comments

@21771
Copy link

21771 commented Apr 14, 2023 •
edited by stress-tess
Loading

Describe the bug
Having issues registering dataframes if they have segarrays. Results in "UnknownSymbolError Line 244 in MultiTypeSymbolTable.checkTable: Error: attrib unkonwn symbol". Am currently using v.03.01 so I can't provide results from current release.

To Reproduce

sega = ak.segarray(ak.arange(0,100,10),ak.arange(100))
df2 = ak.DataFrame({'a':ak.arange(10),'s':sega})
df2 = df2.register('df2')
ak.clear()
df2   # or optionally (df2 = ak.DataFrame.attach('df2'))

Also, if you issue the following commands before those listed above the error appears earlier:

df = ak.DataFrame({'a':ak.arange(10)})
df = df.register('df')
ak.clear()
df

Expected behavior
DataFrames including segarrays should be able to be registered and then should not be affected by ak.clear()

Error Message
"UnknownSymbolError Line 244 in MultiTypeSymbolTable.checkTable: Error: attrib unkonwn symbol"

Is this a Blocking Issue
Not currently a blocking issue. Just requires more resources to ensure sufficient memory without clearing.

ak.get_config() Output
Providing the output of ak.get_config() provides crucial debugging information.

Additional context
Add any other context about the problem here.
@21771 21771 added the bug Something isn't working label Apr 14, 2023
@stress-tess stress-tess self-assigned this Apr 17, 2023
@Ethan-DeBandi99 Ethan-DeBandi99 added the User Reported A user submitted the issue label Apr 18, 2023
stress-tess pushed a commit to stress-tess/arkouda that referenced this issue Apr 24, 2023
Fixes Bears-R-Us#2380: Segarray register bug
6edb29e 
This PR (fixes Bears-R-Us#2380):
- Updates segarray to register it's underlying components. This seems to be necessary anytime these components are exposed to the user (which is why it isn't an issue for segstrings)
- Updates some registration tests to call `ak.clear` to verify that attaching is not relying on any components that just happen to still be present. With the `clear`s, `test_segarray_register_attach` failed before this PR
- Updated `regName` to actually updated `.name` component of the symentry to the new user_defined_name (it kinda blows my mind that this hasn't come up before)

I think going forward we should move this in line with Categorical (perhaps using Registerable and Required pieces), but wanted to keep it straightforward/minimal changes since this is a bug fix
@stress-tess stress-tess mentioned this issue Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stress-tess stress-tess

Labels
bug Something isn't working User Reported A user submitted the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2380: Segarray register bug stress-tess/arkouda
3 participants
@Ethan-DeBandi99 @stress-tess @21771