Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all instances of c_readDatasetNames updated in #2399 #2403

Closed
bmcdonald3 opened this issue Apr 28, 2023 · 0 comments · Fixed by #2404
Closed

Not all instances of c_readDatasetNames updated in #2399 #2403

bmcdonald3 opened this issue Apr 28, 2023 · 0 comments · Fixed by #2404
Labels
bug Something isn't working

Comments

@bmcdonald3
Copy link
Contributor

A fourth argument was added to c_readDatasetNames in #2399, but the extern proc was only updated in one place and there is still another that needs to be updated (lines 914 and 922).
@bmcdonald3 bmcdonald3 added the bug Something isn't working label Apr 28, 2023
bmcdonald3 added a commit to bmcdonald3/arkouda that referenced this issue Apr 28, 2023
@bmcdonald3
Closes Bears-R-Us#2403: Update c_getDatasetNames calls to match new b…
472513f 
…ehavior

In Bears-R-Us#2399, an extra argument was added to `c_getDatasetNames`, but
not all usages in the Chapel code were updated to account for that,
causing undefined behavior from passing garbage memory to the extern
procedure.
@bmcdonald3 bmcdonald3 mentioned this issue Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2403: Update c_getDatasetNames calls to match new behavior bmcdonald3/arkouda
1 participant
@bmcdonald3