Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client_dtypes_test.py conversion for new test framework #2583

Closed
Tracked by #2499
jaketrookman opened this issue Jul 17, 2023 · 0 comments · Fixed by #2592
Closed
Tracked by #2499

client_dtypes_test.py conversion for new test framework #2583

jaketrookman opened this issue Jul 17, 2023 · 0 comments · Fixed by #2592
Assignees
@jaketrookman
Labels
Testing Modifications specific to our test suite.

Comments

@jaketrookman
Copy link
Contributor

jaketrookman commented Jul 17, 2023 •
edited
Loading

Convert client_dtypes_test.py to work in the new test framework. The existing file should be maintained since we will be doing a complete swap once all tests are converted. Only the existing tests need to be converted, there should not be any additional testing that needs to be added.
@jaketrookman jaketrookman mentioned this issue Jul 17, 2023
Open
43 tasks
@jaketrookman jaketrookman self-assigned this Jul 17, 2023
@jaketrookman jaketrookman changed the title client_dtypes_test.py client_dtypes_test.py conversion for new test framework #2537 Jul 17, 2023
@jaketrookman jaketrookman changed the title client_dtypes_test.py conversion for new test framework #2537 client_dtypes_test.py conversion for new test framework #2537 Jul 17, 2023
@jaketrookman jaketrookman added the Testing Modifications specific to our test suite. label Jul 17, 2023
@jaketrookman jaketrookman changed the title client_dtypes_test.py conversion for new test framework #2537 client_dtypes_test.py conversion for new test framework Jul 17, 2023
@jaketrookman jaketrookman mentioned this issue Jul 18, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 14, 2023
@jaketrookman
Closed #2583: client_dtypes_test conversion for new framework (#2592)
ca714a5 
* first round of changes

finishing test update

* adding pytest.prob_size

* missed one

* black formating

* parameterizing test, need to add ip features

parameterized IPv4 tests

* requested changes, unparameterized

rename

* requested changed

* updates

* requested changes

* remove comment

* rename class

* hard coding values and renaming variables

---------

Co-authored-by: jaketrookman <jaketrookman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaketrookman jaketrookman

Labels
Testing Modifications specific to our test suite.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closed #2583: client_dtypes_test conversion for new framework jaketrookman/arkouda
1 participant
@jaketrookman