Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SegArray.append_single not working properly with empty segments #2650

Closed
Ethan-DeBandi99 opened this issue Aug 8, 2023 · 0 comments · Fixed by #2891
Closed

SegArray.append_single not working properly with empty segments #2650

Ethan-DeBandi99 opened this issue Aug 8, 2023 · 0 comments · Fixed by #2891
Assignees
@stress-tess
Labels
bug Something isn't working

Comments

@Ethan-DeBandi99
Copy link
Contributor

The existing test for empty segments does not actually have empty segments. When correcting this in the new platform, I discovered that it is not functioning correctly. The workflow needs to be updated to work correctly when the SegArray contians empty segments.
@Ethan-DeBandi99 Ethan-DeBandi99 added the bug Something isn't working label Aug 8, 2023
@stress-tess stress-tess self-assigned this Sep 8, 2023
stress-tess pushed a commit to stress-tess/arkouda that referenced this issue Dec 21, 2023
Fixes Bears-R-Us#2650: Fixes segarray.append_single with empty segm…
857b1b7 
…ents

This PR (fixes Bears-R-Us#2650) fixes a bug in the way `append_single` handles segarrays with empty segments and adds a test for this
@stress-tess stress-tess mentioned this issue Dec 21, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 21, 2023
@stress-tess
Fixes #2650: Fixes segarray.append_single with empty segments (#2891)
f7d31d8 
This PR (fixes #2650) fixes a bug in the way `append_single` handles segarrays with empty segments and adds a test for this

Co-authored-by: Pierce Hayes <pierce314159@users.noreply.github.com>
ajpotts pushed a commit to ajpotts/arkouda that referenced this issue Jan 2, 2024
@stress-tess @ajpotts
Fixes Bears-R-Us#2650: Fixes segarray.append_single with empty segm…
723a862 
…ents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stress-tess stress-tess

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2650: Fixes segarray.append_single with empty segments stress-tess/arkouda
2 participants
@Ethan-DeBandi99 @stress-tess