Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back python 3.12 check to CI #2843

Closed
stress-tess opened this issue Nov 7, 2023 · 2 comments · Fixed by #2840
Closed

Add back python 3.12 check to CI #2843

stress-tess opened this issue Nov 7, 2023 · 2 comments · Fixed by #2840
Assignees
@stress-tess
Labels
CI Continuous Integration Changes/Updates

Comments

@stress-tess
Copy link
Member

Unpinning tables and pyarrow seems to fix our dependency issues with the 3.12 check. These are the only two deps that have an upper bound so arkouda should be compatible with all the latest versions. I need to double check with @bmcdonald3 to see if the arrow version in the makefile has to match the one in yaml files
@stress-tess stress-tess added the CI Continuous Integration Changes/Updates label Nov 7, 2023
@stress-tess stress-tess self-assigned this Nov 7, 2023
@bmcdonald3
Copy link
Contributor

I don't think it's a big deal if the arrow version match. Parquet is a small part of the arrow library and most of the changes release-to-release for arrow don't actually make any Parquet changes at all, so I don't think the version is particularly important for arrow.

stress-tess pushed a commit to stress-tess/arkouda that referenced this issue Nov 7, 2023
Closes Bears-R-Us#2843: Add python 3.12/3.x check to CI
d6c351d 
This PR (closes Bears-R-Us#2843) adds back the 3.12/3.x python checks to the CI.

Unpinning tables and pyarrow seems to fix our dependency issues with the 3.12 check. These are the only two deps that have an upper bound so arkouda should be compatible with all the latest versions of our dependencies. I need to double check if the arrow version in the makefile has to match the one in yaml files
@stress-tess
Copy link
Member Author

awesome!! Thanks Ben!

@stress-tess stress-tess mentioned this issue Nov 7, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2023
@stress-tess
Closes #2843: Add python 3.12/3.x check to CI (#2840)
58bf71f 
This PR (closes #2843) adds back the 3.12/3.x python checks to the CI.

Unpinning tables and pyarrow seems to fix our dependency issues with the 3.12 check. These are the only two deps that have an upper bound so arkouda should be compatible with all the latest versions of our dependencies. I need to double check if the arrow version in the makefile has to match the one in yaml files

Co-authored-by: Pierce Hayes <pierce314159@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stress-tess stress-tess

Labels
CI Continuous Integration Changes/Updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2843: Add python 3.12/3.x check to CI stress-tess/arkouda
2 participants
@bmcdonald3 @stress-tess