-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inconsistent results when broadcasting with empty segments on multilocale #3035
Labels
Comments
This unexpected result is due to a race condition in this Lines 151 to 153 in 9ab6f17
if we print out the values for segs and diffs we get:
we see that the seg |
I believe the correct result for this case should be My reasoning is:
|
stress-tess
added a commit
to stress-tess/arkouda
that referenced
this issue
Mar 15, 2024
…pty segments This PR (fixes Bears-R-Us#3035) a race condition bug that caused inconsistent results when broadcasting with empty segments (though both results given were incorrect). We get around this by masking out the segments and values associated with the empty segments. We only do this when empty segments exist, so it shouldn't affect the performance of the common case too much but will give correct results in the empty seg case.
github-merge-queue bot
pushed a commit
that referenced
this issue
Mar 18, 2024
…nts (#3039) * Fixes #3035 - Inconsitent results when broadcasting with empty segments This PR (fixes #3035) a race condition bug that caused inconsistent results when broadcasting with empty segments (though both results given were incorrect). We get around this by masking out the segments and values associated with the empty segments. We only do this when empty segments exist, so it shouldn't affect the performance of the common case too much but will give correct results in the empty seg case. * had to add in empty check to avoid a segfault on one of the coargtests --------- Co-authored-by: Tess Hayes <stress-tess@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A user reported this and I was able to reproduce. Below is what I'm seeing with gasnet and 3 locales
The text was updated successfully, but these errors were encountered: