Closes #2431: Add bigint broadcast #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR (closes Bears-R-Us#2431) adds logic and tests for bigint broadcast
stress-tess
requested review from
Ethan-DeBandi99,
joshmarshall1 and
jaketrookman
Ethan-DeBandi99
approved these changes
May 18, 2023
joshmarshall1
approved these changes
May 18, 2023
This was referenced May 22, 2023
bmcdonald3
added a commit
to chapel-lang/chapel
that referenced
this pull request
May 30, 2023
…22402) [ reviewed by @jabraham17 ] Previously, the bigint serialization routines were using plain assignment of the extern `mpz` field, which would result in bad memory accesses, since the `mpz` field had not been initialized. Switching to `mpz_init_set` does both the initialization and assignment. This bug was revealed by Bears-R-Us/arkouda#2437 and a test is added in #22403 for the `+ scan` over a block distributed array that was triggering this. - [x] paratest - [x] paratest gasnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (closes #2431) adds logic and tests for bigint broadcast