Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2433: GroupBy back to client only #2456

Merged

Conversation

stress-tess
Copy link
Member

This PR (closes #2433) goes back to a client only implementation of groupby

This PR (closes Bears-R-Us#2433) goes back to client only implementation of groupby
@stress-tess
Copy link
Member Author

the only code i know of that uses the server side groupby is some stuff @cdhollis94 has been working on. But it shouldn't be too hard to get the same functionality using unique. We can assist with the rewrite if need be

Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just want to verify that one comment is still necessary.

arkouda/groupbyclass.py Show resolved Hide resolved
@Ethan-DeBandi99 Ethan-DeBandi99 added this pull request to the merge queue Jun 1, 2023
Merged via the queue into Bears-R-Us:master with commit fa63c20 Jun 1, 2023
@stress-tess stress-tess deleted the 2433_groupby_client_only branch June 1, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GroupBy Client Side only Implementation
3 participants