Closes #2462: Categorical hashing #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stress-tess
requested review from
Ethan-DeBandi99,
jaketrookman and
TheOddCzar789
stress-tess
force-pushed
the
2462_categorical_hashing
branch
2 times, most recently
from
aafa8a7
to
f3dbd80
Compare
There was a problem hiding this comment.
It looks like there was a lot of # type: ignores added in places I would not have expected. Was there an issue with multiple forward refs that lead to this? It seems odd to me that Categorical is able to be referenced directly where SegArray is referenced as a forward ref. Maybe I am missing something, but maybe we could have a bit of discussion moving forward.
Overall, most the comments are simply suggestions. I do think it would be good to limit how much technical debt is being added, but understand waiting on the JSON return updates.
added 2 commits
June 7, 2023 18:43
This PR (closes Bears-R-Us#2462) adds `categorical.hash()` / `ak.hash(categorical)` and tests for this functionality.
stress-tess
force-pushed
the
2462_categorical_hashing
branch
from
f3dbd80
to
902b8b0
Compare
stress-tess
commented
Jun 8, 2023
jaketrookman
approved these changes
Jun 9, 2023
Ethan-DeBandi99
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (closes #2462) adds
categorical.hash()/ak.hash(categorical)and tests for this functionality.