-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2462: Categorical hashing #2487
Closes #2462: Categorical hashing #2487
Conversation
aafa8a7
to
f3dbd80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there was a lot of # type: ignore
s added in places I would not have expected. Was there an issue with multiple forward refs that lead to this? It seems odd to me that Categorical is able to be referenced directly where SegArray is referenced as a forward ref. Maybe I am missing something, but maybe we could have a bit of discussion moving forward.
Overall, most the comments are simply suggestions. I do think it would be good to limit how much technical debt is being added, but understand waiting on the JSON return updates.
This PR (closes Bears-R-Us#2462) adds `categorical.hash()` / `ak.hash(categorical)` and tests for this functionality.
f3dbd80
to
902b8b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me
This PR (closes #2462) adds
categorical.hash()
/ak.hash(categorical)
and tests for this functionality.