-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design and implement client Channel class hierarchy #2496
Design and implement client Channel class hierarchy #2496
Conversation
…s that encapsulates all ZMQ connection/request logic Bears-R-Us#2495
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know this stuff super well but i don't see any issues other than some docstring stuff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides what was previously mentioned, it looks good
@Ethan-DeBandi99 @pierce314159 @jaketrookman @TheOddCzar789 Updated per Pierce's comments and retested to ensure everything still works: |
Closes #2495
This PR encompasses the design and implementation of a client Channel class hierarchy that fosters support of client/server communication via protocols other than ZMQ, starting with gRPC