Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2504 - Adds New Testing Architecture #2511

Merged
merged 6 commits into from
Jun 22, 2023

Conversation

Ethan-DeBandi99
Copy link
Contributor

Closes #2504

Adds new testing architecture for updates to the testing framework. PROTO_tests directory and pytest_PROTO.ini contain the components required for the new framework. As configured, there will be no interference with running the existing testing in CI. The new framework allows for more customization at runtime of the testing to ensure that we have more coverage. Once the tests are updated, the updated benchmarks that were previously created will be integrated so that we will only need to maintain a single set of configuration files. This format will also support output of JSON logs for testing with the pytest-json-report plugin. This dependency has been added to the arkouda-env-dev.yml file.

numeric_tests.py has been updated to work with the new framework as an example for updating the other test files.

Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

PROTO_tests/conftest.py Outdated Show resolved Hide resolved
PROTO_tests/conftest.py Outdated Show resolved Hide resolved
PROTO_tests/tests/numeric_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/numeric_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/numeric_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/numeric_test.py Outdated Show resolved Hide resolved
PROTO_tests/tests/numeric_test.py Outdated Show resolved Hide resolved
@Ethan-DeBandi99
Copy link
Contributor Author

Adding a note the PR #2447 adds new tests to the numeric_test file. When that is merged, the new testing will need to be updated. That can be done as part of this PR or as a separate PR.

Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

PROTO_tests/tests/numeric_test.py Show resolved Hide resolved
@stress-tess stress-tess added this pull request to the merge queue Jun 22, 2023
Merged via the queue into Bears-R-Us:master with commit 2e21c73 Jun 22, 2023
9 checks passed
@Ethan-DeBandi99 Ethan-DeBandi99 deleted the 2504_new_test_arch branch June 23, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Testing Architecture
3 participants