Closes #2762: Fix last outstanding error regarding OOM handling compat modules #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Bears-R-Us#2760, the compat modules for the 1.32 release switched to using the already created domain to create an array, rather than building the domain from scratch, which was causing some overhead. What that missed was the case where there may be a DR array passed in when you would like to create a block distributed array, so a check on the type of the domain is being added here.
jaketrookman
approved these changes
Sep 11, 2023
stress-tess
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2760, the compat modules for the 1.32 release switched to using the already created domain to create an array, rather than building the domain from scratch, which was causing some overhead. What that missed was the case where there may be a DR array passed in when you would like to create a block distributed array, so a check on the type of the domain is being added here.
Closes #2762