Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2774: Resolve deprecation warnings in advance of 1.32 release #2775

Merged
merged 24 commits into from
Sep 26, 2023

Conversation

bmcdonald3
Copy link
Contributor

@bmcdonald3 bmcdonald3 commented Sep 14, 2023

Deprecations addressed from Chapel 1.32:

  • values modified in loop body must be specified as ref with intents
  • c_string deprecated, not replaced, but can use c_ptrConst(c_char)) now
  • domain.dist deprecated in favor of domain.distribution
  • NAN, INFINITY deprecated in favor of nan and inf
  • casting to bytes/strings deprecated in favor of type method creation functions
  • chpl_task_yield deprecated in favor of currentTask.yieldExecution
  • file reader kind deprecated for use of serializers
  • writeThis deprecated in favor of serialize
  • generic class values must now have (?) to indicate they are generic
  • Block deprecated in favor of blockDist
  • date.isoCalendar deprecated in favor of date.isoWeekDate
  • JsonSerializer changed name to jsonSerializer
  • dateTime.createFromTimestamp deprecated in favor of dateTime.createUtcFromTimestamp().getDate()

Closes #2774

@bmcdonald3 bmcdonald3 force-pushed the 1-32-deprecations branch 11 times, most recently from 33b86a2 to e6e98fe Compare September 20, 2023 22:22
@bmcdonald3 bmcdonald3 marked this pull request as ready for review September 20, 2023 22:22
@bmcdonald3 bmcdonald3 changed the title Closes #2774: 1 32 deprecations Closes #2774: Resolve deprecation warnings in advance of 1.32 release Sep 21, 2023
@bmcdonald3
Copy link
Contributor Author

Converting this PR to a draft as we are discussing on the Chapel team about making the ref changes unstable, rather than generating a deprecation warning (meaning that we wouldn't need to make the changes in Arkouda). If we end up making it unstable, I will undo all the ref changes, which will lessen the impact/size of this round of deprecations on Arkouda.

@bmcdonald3 bmcdonald3 marked this pull request as draft September 22, 2023 15:33
@bmcdonald3 bmcdonald3 marked this pull request as ready for review September 25, 2023 17:01
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small things to look into

src/asd.chpl Outdated Show resolved Hide resolved
src/compat/e-130/ArkoudaSymEntryCompat.chpl Show resolved Hide resolved
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@stress-tess stress-tess added this pull request to the merge queue Sep 26, 2023
Merged via the queue into Bears-R-Us:master with commit 2823dde Sep 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve 1.32 Deprecation warnings
4 participants