-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2774: Resolve deprecation warnings in advance of 1.32 release #2775
Conversation
33b86a2
to
e6e98fe
Compare
with (ref myArray)
should not be required?
chapel-lang/chapel#23488
Converting this PR to a draft as we are discussing on the Chapel team about making the |
e6e98fe
to
a52323e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 small things to look into
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Deprecations addressed from Chapel 1.32:
ref
with intentsc_string
deprecated, not replaced, but can usec_ptrConst(c_char))
nowdomain.dist
deprecated in favor ofdomain.distribution
NAN
,INFINITY
deprecated in favor ofnan
andinf
chpl_task_yield
deprecated in favor ofcurrentTask.yieldExecution
kind
deprecated for use of serializerswriteThis
deprecated in favor ofserialize
(?)
to indicate they are genericBlock
deprecated in favor ofblockDist
date.isoCalendar
deprecated in favor ofdate.isoWeekDate
JsonSerializer
changed name tojsonSerializer
dateTime.createFromTimestamp
deprecated in favor ofdateTime.createUtcFromTimestamp().getDate()
Closes #2774