-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrong MDP file for VDW FEP #20
Comments
@ianmkenney --- I am assigning this to you; please have a look asap. If I find the problem quickly I will notify you through the issue. |
on it |
I think I introduced the bug when I "cleaned up" the parser... 84cf482 Although, not 100% sure on second glances. Anyway, I am on it. |
I think I fixed it with PR #21. I am currently re-running methane. I will close the issue when the results are ok. I can already say, though, that the MDP file looks correct. |
Comparison of the methane run to old runs gave the correct VDW contribution. Fixed! |
Thanks to @iorga for comparison data. |
MDPOW currently creates wrong mdp files for the VDW part of the FEP: The FEP lines read
but this is wrong for the decoupling step where we switch off LJ.
Instead it must be
(as also indicated in the comments in the file itself!)
Any simulations ran with this buggy version are WRONG. I recommend deleting the whole FEP part and running anew (technically, the Coulomb part is correct but it can get messy figuring out what needs to be rerun so I advocated a clean slate).
The text was updated successfully, but these errors were encountered: