Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong MDP file for VDW FEP #20

Closed
orbeckst opened this issue Jan 19, 2016 · 6 comments
Closed

wrong MDP file for VDW FEP #20

orbeckst opened this issue Jan 19, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@orbeckst
Copy link
Member

MDPOW currently creates wrong mdp files for the VDW part of the FEP: The FEP lines read

couple-lambda0 = vdw
couple-lambda1 = vdw-q

but this is wrong for the decoupling step where we switch off LJ.

Instead it must be

couple-lambda0 = vdw
couple-lambda1 = none

(as also indicated in the comments in the file itself!)

Any simulations ran with this buggy version are WRONG. I recommend deleting the whole FEP part and running anew (technically, the Coulomb part is correct but it can get messy figuring out what needs to be rerun so I advocated a clean slate).

@orbeckst orbeckst added the bug label Jan 19, 2016
@orbeckst orbeckst added this to the 0.6 milestone Jan 19, 2016
@orbeckst
Copy link
Member Author

@ianmkenney --- I am assigning this to you; please have a look asap. If I find the problem quickly I will notify you through the issue.

@ianmkenney
Copy link
Member

on it

@orbeckst orbeckst assigned orbeckst and unassigned ianmkenney Jan 20, 2016
@orbeckst
Copy link
Member Author

I think I introduced the bug when I "cleaned up" the parser... 84cf482

Although, not 100% sure on second glances. Anyway, I am on it.

@orbeckst
Copy link
Member Author

I think I fixed it with PR #21. I am currently re-running methane. I will close the issue when the results are ok. I can already say, though, that the MDP file looks correct.

@orbeckst
Copy link
Member Author

Comparison of the methane run to old runs gave the correct VDW contribution. Fixed!

@orbeckst
Copy link
Member Author

Thanks to @iorga for comparison data.

@orbeckst orbeckst mentioned this issue Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants