Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peerDependencies for use-forward-ref and use-stateful-ref packages #1355

Closed
huksley opened this issue Jul 13, 2022 · 0 comments · Fixed by #1356
Closed

Update peerDependencies for use-forward-ref and use-stateful-ref packages #1355

huksley opened this issue Jul 13, 2022 · 0 comments · Fixed by #1356

Comments

@huksley
Copy link

huksley commented Jul 13, 2022

Is your feature request related to a problem? Please describe.

My project is using React 18 and now if I put into dependencies @bedrock-layout/use-forwarded-ref or @bedrock-layout/use-stateful-ref packages (through transitive dependency react-responsive-modal I get warning because of peer dependency requirement.

Describe the solution you'd like
Update peerDependencies to include React 18+

Describe alternatives you've considered
Drop using those packages.

Log

npm WARN @bedrock-layout/use-forwarded-ref@1.3.0 requires a peer of react@^16.8 || ^17 but none is installed. You must install peer dependencies yourself.
npm WARN @bedrock-layout/use-stateful-ref@1.2.1 requires a peer of react@^16.8 || ^17 but none is installed. You must install peer dependencies yourself.
@huksley huksley changed the title Update peerDependencies for use-forward-ref and use-statful-ref packages Update peerDependencies for use-forward-ref and use-stateful-ref packages Jul 13, 2022
Jarvis1010 added a commit that referenced this issue Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant