Allow Symfony 3.4 before bumping v3.0.0 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oliboy50
force-pushed
the
fix/statsdbundle-v3
branch
2 times, most recently
from
a8a51b9
to
ccd7b60
Compare
Merged
Oliboy50
force-pushed
the
fix/statsdbundle-v3
branch
from
ccd7b60
to
a4575f7
Compare
Oliboy50
force-pushed
the
fix/statsdbundle-v3
branch
from
a4575f7
to
12d244f
Compare
DocRoms
approved these changes
Apr 16, 2018
| @@ -5,7 +5,8 @@ php: | |||
| - 7.2 | |||
|
|
|||
| env: | |||
| - SYMFONY_VERSION=4.0.* | |||
| - SYMFONY_VERSION=3.4.0 | |||
There was a problem hiding this comment.
because we say in composer.json that we support at least 3.4.0, so we have to build with this specific minimal version to be sure :)
(3.4.* will install the latest 3.4 version)
chihab-a
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Because we're about to bump a new release
v3.0.0since we've merged #64but before that we should allow users of this new bundle version to run it on Symfony 3.4 (as this is the same as Symfony 4.0 anyway)