chore: support symfony 5

[SelviA]

• DataCollector::collect method signature change since SF 4.4

// before Symfony 4.4
public function collect(Request $request, Response $response, \Exception $exception = null);

// since Symfony 4.4
public function collect(Request $request, Response $response, \Throwable $exception = null);

@see symfony/symfony@ffcfdb4

• Renamed events :
  GetResponseForExceptionEvent replaced by ExceptionEvent
PostResponseEvent replaced by TerminateEvent

• Swap arguments of dispatch()
  @see symfony/symfony@75369da

• Use the spaceless filter instead of spaceless tag (since Twig 1.38)

[Oliboy50]

Thanks 👌

I just wonder why are you dropping older symfony versions support in this PR?

using \Throwable instead of \Exception is not a breaking change for me since Throwable is wider than Exception 🤔

[SelviA]

Hi @Oliboy50,

IMO it's a little bit difficult to keep support of Symfony versions before 4.4 but let's try :

• The signature of the DataCollector::collect method has been updated since 4.4 and unless I am mistaken PHP only supports covariance since 7.4 version (which is supports since 4.4 version of Symfony)
• The signature of the EventDispatcherInterface::dispatch() method has been updated. Maybe we can use the LegacyEventDispatcherProxy decorator as suggests here => I can do it if you want 👍
• For the renamed events GetResponseForExceptionEvent and PostResponseEvent, no idea to keep compatibility.

I think it's better to allow recent applications to use this bundle but I am listening to you if you have any suggestions.

[Oliboy50]

Indeed, full covariance started at php7.4, so you're right, we won't be able to keep symfony <4.4 support here

[Oliboy50]

👌

[SelviA]

@Oliboy50 Ready for a new release ?

[valentin-claras]

Could you please add a new line at the end of this file 🙇

[SelviA]

Are we ready for a new release ?

[Oliboy50]

thank you 👌

=> https://packagist.org/packages/m6web/statsd-bundle#v4.0.0