feat(i18n-lint): use .eslintrc.json as translation files path source #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoquet
changed the title
Pull Request Test Coverage Report for Build 817305868
💛 - Coveralls |
murgatt
approved these changes
May 7, 2021
FakeSkdr
approved these changes
May 10, 2021
nicolasca
approved these changes
May 10, 2021
flepretre
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why ?
As the translation files architecture changed, we need to update how the linter find those files.
how ?
i18n conf already exists for the eslint plugin in the .eslintrc.json file.
The "i18n-lint" command could use this file to know where translation files are located.