Revert "Ports tgui lists (#3366)" (#3980)

This reverts commit c4e375c.

beestation.dme

@@ -3137,7 +3137,6 @@
 #include "code\modules\tgui\external.dm"
 #include "code\modules\tgui\states.dm"
 #include "code\modules\tgui\tgui.dm"
-#include "code\modules\tgui\tgui_input_list.dm"
 #include "code\modules\tgui\tgui_window.dm"
 #include "code\modules\tgui\states\admin.dm"
 #include "code\modules\tgui\states\always.dm"

code/__HELPERS/files.dm

@@ -11,7 +11,7 @@
 		if(path != root)
 			choices.Insert(1,"/")
 
-		var/choice = tgui_input_list(src,"Choose a file to access:","Download",sortList(choices))
+		var/choice = input(src,"Choose a file to access:","Download",null) as null|anything in sortList(choices)
 		switch(choice)
 			if(null)
 				return

code/__HELPERS/unsorted.dm

@@ -1175,7 +1175,7 @@ proc/pick_closest_path(value, list/matches = get_fancy_list_of_atom_types())
 	if(matches.len==1)
 		chosen = matches[1]
 	else
-		chosen = tgui_input_list(usr, "Select a type", "Pick Type", sortList(matches))
+		chosen = input("Select a type", "Pick Type", matches[1]) as null|anything in sortList(matches)
 		if(!chosen)
 			return
 	chosen = matches[chosen]

code/_onclick/hud/ai.dm

@@ -33,7 +33,7 @@
 	if(..())
 		return
 	var/mob/living/silicon/ai/AI = usr
-	var/target_name = tgui_input_list(AI, "Choose who you want to track", "Tracking", AI.trackable_mobs())
+	var/target_name = input(AI, "Choose who you want to track", "Tracking") as null|anything in AI.trackable_mobs()
 	AI.ai_camera_track(target_name)
 
 /atom/movable/screen/ai/camera_light

code/datums/mind.dm

@@ -398,7 +398,7 @@
 		A.admin_remove(usr)
 
 	if (href_list["role_edit"])
-		var/new_role = tgui_input_list(usr,"Select new role", "Assigned role", sortList(get_all_jobs()))
+		var/new_role = input("Select new role", "Assigned role", assigned_role) as null|anything in sortList(get_all_jobs())
 		if (!new_role)
 			return
 		assigned_role = new_role
@@ -411,6 +411,7 @@
 
 	else if (href_list["obj_edit"] || href_list["obj_add"])
 		var/objective_pos //Edited objectives need to keep same order in antag objective list
+		var/def_value
 		var/datum/antagonist/target_antag
 		var/datum/objective/old_objective //The old objective we're replacing/editing
 		var/datum/objective/new_objective //New objective we're be adding
@@ -437,9 +438,7 @@
 					if(1)
 						target_antag = antag_datums[1]
 					else
-						var/datum/antagonist/target = tgui_input_list(usr, "Which antagonist gets the objective:", "Antagonist", sortList(antag_datums) + "(new custom antag)")
-						if(!target)
-							target = "(new custom antag)"
+						var/datum/antagonist/target = input("Which antagonist gets the objective:", "Antagonist", "(new custom antag)") as null|anything in sortList(antag_datums) + "(new custom antag)"
 						if (QDELETED(target))
 							return
 						else if(target == "(new custom antag)")
@@ -450,7 +449,11 @@
 		if(!GLOB.admin_objective_list)
 			generate_admin_objective_list()
 
-		var/selected_type = tgui_input_list(usr, "Select objective type:", "Objective type", GLOB.admin_objective_list)
+		if(old_objective)
+			if(old_objective.name in GLOB.admin_objective_list)
+				def_value = old_objective.name
+
+		var/selected_type = input("Select objective type:", "Objective type", def_value) as null|anything in GLOB.admin_objective_list
 		selected_type = GLOB.admin_objective_list[selected_type]
 		if (!selected_type)
 			return

code/datums/mutations/actions.dm

@@ -64,7 +64,7 @@
 		if(!length(possible))
 			to_chat(user,"<span class='warning'>Despite your best efforts, there are no scents to be found on [sniffed]...</span>")
 			return
-		tracking_target = tgui_input_list(user, "Choose a scent to remember.", "Scent Tracking", sortNames(possible))
+		tracking_target = input(user, "Choose a scent to remember.", "Scent Tracking") as null|anything in sortNames(possible)
 		if(!tracking_target)
 			if(!old_target)
 				to_chat(user,"<span class='warning'>You decide against remembering any scents. Instead, you notice your own nose in your peripheral vision. This goes on to remind you of that one time you started breathing manually and couldn't stop. What an awful day that was.</span>")

code/game/atoms.dm

@@ -957,7 +957,7 @@
 						if(!valid_id)
 							to_chat(usr, "<span class='warning'>A reagent with that ID doesn't exist!</span>")
 				if("Choose from a list")
-					chosen_id = tgui_input_list(usr, "Choose a reagent to add.", "Choose a reagent.", subtypesof(/datum/reagent))
+					chosen_id = input(usr, "Choose a reagent to add.", "Choose a reagent.") as null|anything in subtypesof(/datum/reagent)
 				if("I'm feeling lucky")
 					chosen_id = pick(subtypesof(/datum/reagent))
 			if(chosen_id)

code/game/gamemodes/objective.dm

@@ -28,11 +28,16 @@ GLOBAL_LIST_EMPTY(objectives)
 //Shared by few objective types
 /datum/objective/proc/admin_simple_target_pick(mob/admin)
 	var/list/possible_targets = list("Free objective","Random")
+	var/def_value
 	for(var/datum/mind/possible_target in SSticker.minds)
 		if ((possible_target != src) && ishuman(possible_target.current))
 			possible_targets += possible_target.current
 
-	var/mob/new_target = tgui_input_list(admin,"Select target:", "Objective target", sortNames(possible_targets))
+
+	if(target?.current)
+		def_value = target.current
+
+	var/mob/new_target = input(admin,"Select target:", "Objective target", def_value) as null|anything in sortNames(possible_targets)
 	if (!new_target)
 		return
 

code/game/machinery/camera/tracking.dm

@@ -16,7 +16,7 @@
 
 /mob/living/silicon/ai/proc/show_camera_list()
 	var/list/cameras = get_camera_list()
-	var/camera = tgui_input_list(src, "Choose which camera you want to view", "Cameras", cameras)
+	var/camera = input(src, "Choose which camera you want to view", "Cameras") as null|anything in cameras
 	switchCamera(cameras[camera])
 
 /datum/trackable

code/game/machinery/hologram.dm

@@ -270,7 +270,7 @@ Possible to do for anyone motivated enough:
 					LAZYADD(callnames[A], I)
 			callnames -= get_area(src)
 
-			var/result = tgui_input_list(usr, "Choose an area to call", "Holocall", sortNames(callnames))
+			var/result = input(usr, "Choose an area to call", "Holocall") as null|anything in sortNames(callnames)
 			if(QDELETED(usr) || !result || outgoing_call)
 				return
 

code/game/objects/items/holy_weapons.dm

@@ -234,7 +234,7 @@
 		if (initial(rodtype.chaplain_spawnable))
 			display_names[initial(rodtype.name)] = rodtype
 
-	var/choice = tgui_input_list(M,"What theme would you like for your holy weapon?","Holy Weapon Theme", sortList(display_names, /proc/cmp_typepaths_asc))
+	var/choice = input(M,"What theme would you like for your holy weapon?","Holy Weapon Theme") as null|anything in sortList(display_names, /proc/cmp_typepaths_asc)
 	if(QDELETED(src) || !choice || M.stat || !in_range(M, src) || M.incapacitated() || reskinned)
 		return
 

code/modules/mob/living/simple_animal/bot/mulebot.dm

@@ -246,7 +246,7 @@
 		if("destination")
 			var/new_dest
 			if(pda)
-				new_dest =  tgui_input_list(user, "Enter Destination:", name, GLOB.deliverybeacontags)
+				new_dest = input(user, "Enter Destination:", name, destination) as null|anything in GLOB.deliverybeacontags
 			else
 				new_dest = params["value"]
 			if(new_dest)
@@ -262,7 +262,7 @@
 		if("sethome")
 			var/new_home
 			if(pda)
-				new_home = tgui_input_list(user, "Enter Home:", name, GLOB.deliverybeacontags)
+				new_home = input(user, "Enter Home:", name, home_destination) as null|anything in GLOB.deliverybeacontags
 			else
 				new_home = params["value"]
 			if(new_home)

code/modules/modular_computers/computers/item/computer.dm

@@ -419,7 +419,7 @@
 			var/obj/item/computer_hardware/H = all_components[h]
 			component_names.Add(H.name)
 
-		var/choice = tgui_input_list(user, "Which component do you want to uninstall?", "Computer maintenance", sortList(component_names))
+		var/choice = input(user, "Which component do you want to uninstall?", "Computer maintenance", null) as null|anything in sortList(component_names)
 
 		if(!choice)
 			return

code/modules/shuttle/assault_pod.dm

@@ -35,7 +35,7 @@
 
 /obj/item/assault_pod/attack_self(mob/living/user)
 	var/target_area
-	target_area = tgui_input_list(user, "Area to land", "Select a Landing Zone", GLOB.teleportlocs)
+	target_area = input("Area to land", "Select a Landing Zone", target_area) as null|anything in GLOB.teleportlocs
 	if(!target_area)
 		return
 	var/area/picked_area = GLOB.teleportlocs[target_area]

code/modules/spells/spell_types/area_teleport.dm

@@ -25,7 +25,7 @@
 	var/A = null
 
 	if(!randomise_selection)
-		A = tgui_input_list(usr, "Area to teleport to", "Teleport", GLOB.teleportlocs)
+		A = input("Area to teleport to", "Teleport", A) as null|anything in GLOB.teleportlocs
 	else
 		A = pick(GLOB.teleportlocs)
 	if(!A)

code/modules/surgery/helpers.dm

@@ -44,7 +44,7 @@
 		if(!available_surgeries.len)
 			return
 
-		var/P = tgui_input_list(user, "Begin which procedure?", "Surgery", sortList(available_surgeries))
+		var/P = input("Begin which procedure?", "Surgery", null, null) as null|anything in sortList(available_surgeries)
 		if(P && user && user.Adjacent(M) && (I in user))
 			var/datum/surgery/S = available_surgeries[P]