Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ports tgui lists #3366

Merged
merged 27 commits into from
Mar 23, 2021
Merged

Ports tgui lists #3366

merged 27 commits into from
Mar 23, 2021

Conversation

jupyterkat
Copy link
Contributor

@jupyterkat jupyterkat commented Jan 12, 2021 •
edited
Loading

About The Pull Request

Ports tgui lists from tgstation/tgstation#56065

Why It's Good For The Game

Reactive UIs are always good

Changelog

🆑Watermelon914
add: Added tgui lists
/:cl:

Jupyterkat and others added 2 commits January 12, 2021 20:20
@jupyterkat @Watermelon914
init
f1dbefa 
Co-Authored-By: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
@jupyterkat @Watermelon914
adds usage
3a966b8 
Co-Authored-By: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
@jupyterkat
Copy link
Contributor Author

UIs not opening, fix soon:tm:

@Crossedfall Crossedfall marked this pull request as draft January 12, 2021 20:44
@Crossedfall
Copy link
Member

UIs not opening, fix soon™️

Converting this to a draft. Mark it as ready for review when things are fixed up.

@jupyterkat jupyterkat marked this pull request as ready for review January 13, 2021 08:09
@jupyterkat
Copy link
Contributor Author

Working correctly now
image

@jupyterkat jupyterkat closed this Jan 13, 2021
@Crossedfall
Copy link
Member

If it works, why close the PR?

@Crossedfall Crossedfall reopened this Jan 13, 2021
@jupyterkat
Copy link
Contributor Author

woops, pressed that by a mistake

@PowerfulBacon PowerfulBacon added Needs Testmerge Test Merged This PR is currently in rotation and removed Needs Testmerge Test Merged This PR is currently in rotation labels Jan 25, 2021
PowerfulBacon
PowerfulBacon requested changes Jan 25, 2021
View reviewed changes
Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@github-actions
Copy link

github-actions bot commented Mar 7, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PowerfulBacon PowerfulBacon added the Test Merged This PR is currently in rotation label Mar 21, 2021
@PowerfulBacon
Copy link
Member

Seems alright in testmerge

@ike709 ike709 merged commit c4e375c into BeeStation:master Mar 23, 2021
@ghost ghost mentioned this pull request Mar 23, 2021
Merged
@aquila33-bot aquila33-bot mentioned this pull request Mar 23, 2021
Merged
@AustationBot AustationBot mentioned this pull request Mar 23, 2021
Merged
@PolyTheParrot-PR PolyTheParrot-PR mentioned this pull request Mar 23, 2021
Merged
ss13-beebot added a commit that referenced this pull request Mar 23, 2021
@ss13-beebot
Automatic changelog generation for PR #3366 [ci skip]
fa4ef43
@francinum
Copy link
Contributor

Wow, this is actively less useful.

Enter no longer selects the currently selected item.
Movement keys are no longer eaten and thus you will change selection while moving and vice versa.

francinum added a commit that referenced this pull request Mar 24, 2021
@francinum
Revert "Ports tgui lists (#3366)"
ac74c61 
This reverts commit c4e375c.
@francinum francinum mentioned this pull request Mar 24, 2021
Closed
@bloons3
Copy link
Contributor

bloons3 commented Mar 24, 2021

Perhaps not everything should have been made a TGUI list until their underlying issues were worked out

@jupyterkat
Copy link
Contributor Author

@bloons3 I'll fix it soon enough:tm:

@jupyterkat jupyterkat deleted the tgui-lists branch March 25, 2021 10:02
francinum added a commit to francinum/BeeStation-Hornet that referenced this pull request Mar 27, 2021
@francinum
Revert "Ports tgui lists (BeeStation#3366)"
32afb41 
This reverts commit c4e375c.
PowerfulBacon pushed a commit that referenced this pull request Mar 27, 2021
@francinum
Revert "Ports tgui lists (#3366)" (#3980)
dd12575 
This reverts commit c4e375c.
jupyterkat added a commit to jupyterkat/BeeStation-Hornet that referenced this pull request Mar 27, 2021
@jupyterkat
Revert "Revert "Ports tgui lists (BeeStation#3366)" (BeeStation#3980)"
a9d1160 
This reverts commit dd12575.
@jupyterkat jupyterkat restored the tgui-lists branch April 18, 2021 23:17
@Bobbanz1 Bobbanz1 mentioned this pull request Jun 22, 2022
Merged
@itsmeow itsmeow removed the Test Merged This PR is currently in rotation label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PowerfulBacon PowerfulBacon PowerfulBacon approved these changes

Assignees
No one assigned
Labels
Feature TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jupyterkat @Crossedfall @PowerfulBacon @francinum @bloons3 @ike709 @itsmeow