Port chat reliability subsystem from /tg/ #10367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
TGUI-Changes
EvilDragonfiend
added
Test Merged
|
eh, mistake. it really didn't pass.
|
…cording to git blame
|
@itsmeow this already has that lol |
|
Is this good to go? |
|
@itsmeow Code owner review |
itsmeow
approved these changes
Feb 15, 2024
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
* Port chat reliability subsystem from /tg/ * This crash isn't needed, seems to just be a /tg/ "cleanup" runtime according to git blame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tgstation/tgstation#79479, tgstation/tgstation#79819, and tgstation/tgstation#79821.
Fixes #9050
Why It's Good For The Game
Should get rid of that annoying bug where random chat messages rarely get "swallowed" and never appear for certain people.
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑 ZephyrTFA, Absolucy
add: Chat Reliability Layer
code: TGUI chat messages now track their sequence and will be resent if the client notices a discrepenency
/:cl: