Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes sending stuff to "Old" Chat #79819

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Conversation

san7890
Copy link
Member

@san7890 san7890 commented Nov 18, 2023

About The Pull Request

This functionality was removed in #79479 (e1c6cfd), and we should still be supporting the old chat anyways because it contains a plethora of useful BYOND information that we still can really leverage (such as the built-in profiler and stuff like that) and it's going to be painful to do that if you have to keep spamming fix-chat to see OOC/ASAY while alternating every damn time.

Why It's Good For The Game

It's ugly but we still need it. There's a reason why we still have it.

Changelog

馃啈
fix: "Old Chat" (AKA: The old-styled non-TGUI raw-HTMLesque chat that you might see when it prods you with the "Failed to load fancy chat!" issue) should now get all text messages as expected.
/:cl:

@tgstation-server tgstation-server added the Fix Rewrites a bug so it appears in different circumstances label Nov 18, 2023
@ZephyrTFA ZephyrTFA added the Priority: High We messed up. label Nov 18, 2023
@ZephyrTFA ZephyrTFA merged commit eb246c2 into tgstation:master Nov 18, 2023
21 checks passed
comfyorange added a commit that referenced this pull request Nov 18, 2023
github-actions bot added a commit that referenced this pull request Nov 18, 2023
dwasint pushed a commit to dwasint/Monkestation2.0 that referenced this pull request Dec 24, 2023
## About The Pull Request

This functionality was removed in tgstation#79479
(e1c6cfd), and we should still be
supporting the old chat anyways because it contains a plethora of useful
BYOND information that we still can really leverage (such as the
built-in profiler and stuff like that) and it's going to be painful to
do that if you have to keep spamming `fix-chat` to see OOC/ASAY while
alternating every damn time.
## Why It's Good For The Game

It's ugly but we still need it. There's a reason why we still have it.
## Changelog
:cl:
fix: "Old Chat" (AKA: The old-styled non-TGUI raw-HTMLesque chat that
you might see when it prods you with the "Failed to load fancy chat!"
issue) should now get all text messages as expected.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances Priority: High We messed up.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants