New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports holding down space to toggle throw mode from tg #6493
Conversation
can't you already do this with the R key? |
if(iscarbon(user)) | ||
var/mob/living/carbon/C = user | ||
C.throw_mode_on() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing this? When you prime a grenade, throw mode should be entered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhh, no this is specific to this fruit for whatever reason. Regular grenades don't toggle your throw mode, so it's for consistency's sake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regular grenades can be thrown while primed, even if not in throw mode.
Pretty certain regular grenades like minibombs toggle on throw mode when you prime them, if not they should |
I don't think they should. We should at least be consistent about nades auto priming instead of some priming and some not. |
If you prime a grenade and click, the grenade gets thrown even when not in throw mode. |
if(in_throw_mode && throw_item(A)) | ||
return | ||
|
||
var/obj/item/W = get_active_held_item() | ||
|
||
if(throw_mode && W) | ||
changeNext_move(CLICK_CD_THROW) | ||
throw_item(A) | ||
return | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broke logic
About The Pull Request
PORTS: tgstation/tgstation#57331
Title. Allows holding down space to toggle throw mode. Also removes a few things automatically toggling your throw mode, mainly priming exploding lemons from botany. Adds a CD for throwing stuff too.
Why It's Good For The Game
Being able to catch things as a moments notice is vital when fighting experienced players who know how good thrown weapons are (read: bolas).
Testing Photographs and Procedure
Screenshots&Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.catdrink.mp4
Changelog
馃啈
add: You can now toggle throw mode by pressing space bar!
/:cl: