Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to relaunch the game alongside reconnect when you lose connection #8166

Merged
merged 2 commits into from
Dec 10, 2022

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Dec 5, 2022

Ports:

About The Pull Request

.reconnect is not the most reliable thing in the world, and will collapse given any topic call. This will give players a new button in the case that all other buttons fail

Why It's Good For The Game

Testing Photographs and Procedure

image

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Mothblocks, RKz
qol: Additional button has been added to tgchat connection closed warning, allowing users to reopen the game in addition to reconnect
/:cl:

@github-actions github-actions bot added the TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 label Dec 5, 2022
@Tsar-Salat Tsar-Salat marked this pull request as ready for review December 5, 2022 04:04
@PowerfulBacon
Copy link
Member

Do we need both buttons, or would just relaunch be good enough? (Will people actually use reconnect if relaunch does the same thing but more powerfully?)

@Tsar-Salat
Copy link
Contributor Author

Tsar-Salat commented Dec 5, 2022

(Will people actually use reconnect if relaunch does the same thing but more powerfully?)

I dont understand what you mean by "more powerfully".

It takes longer and might send the client through Byond's ad bullshit or whatever. Its meant to be used when reconnect doesnt work. Reconnect will be still preferable for the average user.

For 90% of connection issues, reconnect will work just fine, and basically instantly. This PR is meant for the 10% where window gets stuck in limbo with either lost connection, broken chatboxes, or broken TGUI and the user starts mhelping for an issue that can be easily solved with a single relaunch

@PowerfulBacon
Copy link
Member

I feel like people will use relaunch game in situations where reconnect would work, just simply because reconnect has absolutely 0 feedback and no indication that its actually work, where as this one closes and re-opens the game which is a clear indication that it did what you wanted.

@Tsar-Salat
Copy link
Contributor Author

Tsar-Salat commented Dec 5, 2022

just simply because reconnect has absolutely 0 feedback and no indication that its actually work

I agree.
However, if someone is pissed off or impatient enough, they are going to X out of the game and reload anyway. The relaunch is just a shortcut to what they would do anyway.

If its a simple disconnection or chatbox issue, the reconnect will fix it in 3(incredible guesstimation) seconds.

On the reconnect not providing feedback, I agree, however that is outside the scope of this pr. I don't know how to realistically have the window print reconnect's progress, especially with fancychat

tgui/packages/tgui-panel/reconnect.tsx Outdated Show resolved Hide resolved
@PowerfulBacon PowerfulBacon self-requested a review December 7, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants