Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to relaunch the game alongside reconnect when you lose connection #66220

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

Mothblocks
Copy link
Member

About The Pull Request

Requested by @MrStonedOne.

.reconnect is not the most reliable thing in the world, and will collapse given any topic call. stylemistake is currently working on fixing the auto-reconnect's (and some others) biggest blunder by changing how ping works, but this is nice as a fallback for when all else fails.

Changelog

🆑
qol: The reconnect button in tgchat will now reopen the game.
/:cl:

@tgstation-server tgstation-server added Quality of Life Increasing esword damage is not a quality of life for traitors UI We make the game less playable, but with round edges labels Apr 16, 2022
@stylemistake

This comment was marked as outdated.

@stylemistake
Copy link
Member

stylemistake commented Apr 16, 2022

Ok, an even bigger brain solution:

Byond.winget('', 'url').then((serverUrl) => {
  Byond.call(serverUrl);
  Byond.command('.quit');
});

If you want Byond.winget(null, 'url') support, merge #65943 first.

@Mothblocks
Copy link
Member Author

Mothblocks commented Apr 16, 2022

Per Discord (posting here for posterity), I think we can't use that API since it can sometimes return blank, like during reconnect, so I'm going to bundle it with tgui.html instead? Right? Which path are we taking here?

@stylemistake
Copy link
Member

You can do that winget multiple times on interval to keep an up-to-date non-null URL.

@Mothblocks
Copy link
Member Author

Aye 👍

@Mothblocks Mothblocks changed the title Change tgchat reconnect button to reopen the game instead of using .reconnect Add button to relaunch the game alongside reconnect when you lose connection Apr 16, 2022
@Mothblocks Mothblocks marked this pull request as draft April 17, 2022 03:51
@Mothblocks
Copy link
Member Author

According to MSO, sometimes the port is :0. I'm gonna change the code to detect when we get :0, and keep the old port.

@RikuTheKiller
Copy link
Contributor

This is one godsend of a PR.

@Mothblocks Mothblocks marked this pull request as ready for review April 20, 2022 09:00
@Mothblocks
Copy link
Member Author

TIL: Internet Explorer does not support endsWith

@stylemistake
Copy link
Member

It's a polyfill issue, core-js should've filled you in on this

@stylemistake stylemistake merged commit 1b06fed into tgstation:master Apr 20, 2022
github-actions bot added a commit that referenced this pull request Apr 20, 2022
SplinterGP added a commit to SplinterGP/TerraGov-Marine-Corps that referenced this pull request Jul 1, 2022
TiviPlus pushed a commit to tgstation/TerraGov-Marine-Corps that referenced this pull request Nov 12, 2022
* tgui input hotfix tgstation/tgstation#64698

* changes how tgui handles static data tgstation/tgstation#64757

* tgstation/tgstation#64885

* tgstation/tgstation#65008

* cooldown check

* read preferences doenst exist here

* tgstation/tgstation#65378

* Adds support for embedding react components in tgui chat

* tgstation/tgstation#65686

* tgstation/tgstation#65943

* previous part 2

* oops forgot

* tgstation/tgstation#66220

* tgstation/tgstation#66299

* FUCk forgot 1

* tgstation/tgstation#59914

* tgstation/tgstation#66304

* tgstation/tgstation#66309

* tgstation/tgstation#66317

* tgstation/tgstation#66691

* tgstation/tgstation#66757

* small changes from 66933

* tgstation/tgstation#67137

* tgui part of tgstation/tgstation#67691 and tgstation/tgstation#66971

* forgot public html

* tgstation/tgstation#67935 prewritepackages

* after write packages

* tgstation/tgstation#67937

* oops

* tgstation/tgstation#68216

* tgstation/tgstation#68356

* tgstation/tgstation#68679

* tgstation/tgstation#68887

* prettier ignore outside

* tgstation/tgstation#69219

* tgstation/tgstation#69459

* tgstation/tgstation#69527

* tgstation/tgstation#69735

* tgstation/tgstation#69786

* tgstation/tgstation#70779

* boop

* Update code/modules/mob/living/silicon/ai/examine.dm

* fix ?

* io

* yo

* prettier

* prettier + other stuff + tgui say etc

* okay ?

* webpack tguisay

* ntoswindow

* tguialert move

* tgui say work ?

* tgstation/tgstation#71037

* rollback tguisay

* comment out tgui say

* remove tguisay dm files

* updates tgui folder

* whytflinter

* rerun

* fixes stack trace on fullupdate

* woops, removes \n from join()

* balloon alert

* timeleft shenanigan solve stack_trace

* check if fix linter

* add it back

* woo linter
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Mar 12, 2023
… lose connection (tgstation#518)

* Add button to relaunch the game alongside reconnect when you lose connection (tgstation#66220)

* Change reconnect button to reopen the game

* Two buttons

* Use winget

* Don't allow :0 ports, whatever

* Add button to relaunch the game alongside reconnect when you lose connection

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Debian <debian@packer-output-01d6f1be-59bf-4994-80ec-c61b12fe30e1>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Increasing esword damage is not a quality of life for traitors UI We make the game less playable, but with round edges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants