Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the SM auxgm-based #8799

Closed
wants to merge 1 commit into from

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Apr 2, 2023

Ports:

About The Pull Request

Shifts a bunch of hardcoded stuff to auxgm. Removes duplicate defines. Added better docs to supermatter

Why It's Good For The Game

We should be using auxgm for this.
This PR is needed for 5 gas port in a later pr.

Testing Photographs and Procedure

Screenshots&Videos

Operates normally. o2 plasma and co2 all have normal properties
operatesnormally

I spawned about 30 trit cans in there to see a good delam. good reactions so far
goodreact

still working
goodreact2

delamming fine
goodsds

Explosion range within normal parameters
Uploading normal explosion range.PNG…

Changelog

🆑 RKz ,Putnam3145, Dwasint
refactor: Supermatter values use auxgm
/:cl:

@itsmeow
Copy link
Member

itsmeow commented Apr 3, 2023

What the hell is auxgm

@PowerfulBacon
Copy link
Member

We are trying to move away from auxmos and towards the LINDA implementation that TG has

@Tsar-Salat
Copy link
Contributor Author

We are trying to move away from auxmos and towards the LINDA implementation that TG has

I've seen that said, but I really haven't seen any action towards actually doing so. I assumed that was not actually true, my apologies.

That does bode well for my plans, however.

I will retool the 8 gas pr to work without auxgm changes, and start bringing back pre-auxtool defines in another pr.

@Tsar-Salat
Copy link
Contributor Author

This pr is no longer necessary.

@Tsar-Salat Tsar-Salat closed this Apr 5, 2023
@Tsar-Salat Tsar-Salat deleted the auxgm-supermatter branch April 5, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants