Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes spider venom / nanite interactions #8960

Merged
merged 1 commit into from
May 7, 2023

Conversation

Rukofamicom
Copy link
Contributor

@Rukofamicom Rukofamicom commented Apr 30, 2023

About The Pull Request

Changes the nanites software error from type 5 to type 1.
Instead of forcing all programs to glitch, it will now delete all programs instead.

Why It's Good For The Game

This fixes a critical oversight in #8789
I was mistaken and in fact not all nanite programs become /datum/nanite_program/glitch when subjected to corruption, it's just the default and by far most common option.

Spider venom is incredibly lethal to people who have specific nanite programs in their system currently and this is not intended behavior.

Testing Photographs and Procedure

As outlined in #8789:

image

I am still unable to actually test this specific facet of the code.

Changelog

🆑
fix: Fixed an unintended interaction between spider venom and nanites. Spider venom will still render nanites inert, but they will no longer be drained automatically after this.
/:cl:

@Absolucy
Copy link
Contributor

you can test using a nanite cloud + public nanite chamber, fyi. actually don't even need the public nanite chamber, just use aghost and admin ai interact with the normal nanite chamber and set your cloud id.

@Rukofamicom
Copy link
Contributor Author

Rukofamicom commented Apr 30, 2023

just use aghost and admin ai interact with the normal nanite chamber and set your cloud id.

I literally don't know what this means. Like I said in the screencapped bit taken from the other PR - I tried learning nanites properly from wiki and couldn't make sense of it at all, and nothing about doing them is intuitive in-game either. I can't use admin tools to force nanites into what I want when I don't even know what I'm forcing. Everything I know about nanites I know from code-diving.

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just nerf healing nanites if its got to the point where combat requires specific handling to nullify nanites

@PowerfulBacon PowerfulBacon added this pull request to the merge queue May 7, 2023
Merged via the queue into BeeStation:master with commit bff0ea3 May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants