-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PORT] Cargo and Cyborg Munitions Upgrade #2427
Merged
Bokkiewokkie
merged 10 commits into
BeeStation:master
from
Bobbanz1:CargoMuniBorgRework
Jul 28, 2023
Merged
[PORT] Cargo and Cyborg Munitions Upgrade #2427
Bokkiewokkie
merged 10 commits into
BeeStation:master
from
Bobbanz1:CargoMuniBorgRework
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
As discussed, munitions borg really needs more modules to make it unique and worthwhile. Also 0/10 for the sprite not being a vtol minifighter. |
Adds other stuff to the module
Bobbanz1
changed the title
[PORT] Cargo and Munitions Borg
[PORT] Cargo and Munitions Module Upgrade
May 29, 2023
Bobbanz1
changed the title
[PORT] Cargo and Munitions Module Upgrade
[PORT] Cargo and EngiBorg Munitions Upgrade
May 29, 2023
Bobbanz1
changed the title
[PORT] Cargo and EngiBorg Munitions Upgrade
[PORT] Cargo and Cyborg Munitions Upgrade
May 29, 2023
Bokkiewokkie
added
Feature
Balance/Rebalance
Active Test Merge
Munitions
Issues and pull requests related to munitions.
Refactor
labels
Jun 30, 2023
Closed
This was referenced Jul 17, 2023
Bokkiewokkie
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature creep confirmed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Active Test Merge
Balance/Rebalance
Feature
Munitions
Issues and pull requests related to munitions.
Port
Ports code from a codebase other than Beestation
Refactor
Sound
Sprites
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
What this PR in simplicity does is it adds the following:
Ports from: Skyrat-TG
Ports from: TGstation
Why It's Good For The Game
Allows for future implementation of additional borg module icons rather than the static ones we currently have.
Allows for a borg to do Cargo work and free up the space if it so desires.
Allows for engineering borgs to finally help their Munition Comrades in making stuff go boom!
Testing Photographs and Procedure
Screenshots&Videos
2023-05-29.14-07-18.mp4
2023-05-25.18-35-27.mp4
Changelog
🆑Bobbanz1, KasparoVy, Fikou, Seris02, GoldenAlpharex, Serijas for the Cyborg sprites, Reco201
add: Added a new cyborg module: Cargo Cyborgs! Paperwork experts and aces at delivery, they'll truly complement the Silicon gameplay by finally allowing you to scratch that forms-filling itch you had for so long!
fix: Fixed cyborgs re-generating a bunch of icons every time they'd pick a model, with more optimizations to that to come.
add: Cargo Borgs now come equip with a export scanner.
add: Added a new cyborg upgrade to Engineering borgs which allows them to perform some munitions work!
refactor: refactored the borg icon stuff to allow for easier implementation of other skins for borg modules
balance: Cargoborgs upgraded clamp can now carry two wrapped crates instead of one.
/:cl: