[PORT] Navbeacon Refactor #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bokkiewokkie
added
Mass Map Change
|
Bobbanz on their way to once again port a mass map change PR |
I'm not porting it to Bee I DON'T WANT TO HAVE TO GO THROUGH ALL THEIR MAPS AND MAKE THEIR CHANGES |
Bokkiewokkie
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports a few things from TG-Station
Namely the following:
What those two PRs accomplish is that they more or less just overhaul the Navbeacon, last PR lets you build new onces and even deconstruct existing ones, it also makes it way more easier to figure out what the hell the code stuff actually means in-round, letting you perhaps fix existing routes or improve on them.
Oh and it also gives the navbeacon an actual TGUI rather than the existing href thingy we currently have which makes it so much more easier to interact with.
Oh and that refactor PR makes it much MUCH more easier to figure out how to make the delivery navbeacons put down stuff in a correct way!
Definition of Insanity
Why It's Good For The Game
DEATH TO THE OLD NAVBEACONS LONG LIVE THE NEW INTERFACEMakes it more easier to interact with the navbeacons in round, also makes it so much less confusing to figure out how to make delivery beacons place stuff correctly
Testing Photographs and Procedure
Screenshots&Videos
2023-07-20.21-30-41.mp4
Changelog
🆑cacogen, Profakos
fix: Modifying a navigation beacon's codes list or location name now correctly updates the associated global lists
refactor: Refactored navigational beacons, making them constructable, deconstructable, and generally easier to use
/:cl: