Update dependency electron to v9 [SECURITY] (#947)

Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Adam <adam.lj.haglund@gmail.com>
beeequeue · Mar 16, 2021 · 44f8289 · 44f8289
1 parent f649b21
commit 44f8289
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 15 deletions.
diff --git a/.browserslistrc b/.browserslistrc
@@ -1 +1 @@
-Chrome >= 69
+Electron > 9 and Electron < 10
diff --git a/.postcssrc.js b/.postcssrc.js
diff --git a/package.json b/package.json
@@ -134,7 +134,7 @@
     "browserslist": "4.16.0",
     "cross-env": "7.0.3",
     "deepmerge": "4.2.2",
-    "electron": "8.3.1",
+    "electron": "9.4.4",
     "eslint": "7.15.0",
     "eslint-plugin-prettier": "3.3.0",
     "eslint-plugin-vue": "7.2.0",

diff --git a/src/background.ts b/src/background.ts
@@ -27,11 +27,11 @@ import {
   REGISTER_MEDIA_KEYS,
   UNREGISTER_MEDIA_KEYS,
 } from "./messages"
-import { initUpdateChecker } from "./updater"
+import { initUpdateChecker } from "./background/updater"
 import { version } from "../package.json"
 import { SupportedMediaKeys } from "@/types"
 import { clamp, debounce, enumKeysToArray } from "@/utils"
-import { downloadBinariesIfNecessary } from "@/lib/ffmpeg/download"
+import { downloadBinariesIfNecessary } from "@/lib/ffmpeg"
 
 const isDevelopment = process.env.NODE_ENV !== "production"
 if (isDevelopment) {
@@ -135,6 +135,7 @@ const createMainWindow = () => {
       webSecurity: false,
       allowRunningInsecureContent: false,
       nodeIntegration: (process.env.ELECTRON_NODE_INTEGRATION as unknown) as boolean,
+      contextIsolation: false,
     },
   })
 

diff --git a/src/updater.ts → src/background/updater.ts b/src/updater.ts → src/background/updater.ts
@@ -4,8 +4,8 @@ import { activeWindow } from "electron-util"
 import fetch from "node-fetch"
 import { lte } from "semver"
 
+import { CHECK_FOR_UPDATES, UPDATE_AVAILABLE } from "@/messages"
 import { isNil } from "@/utils"
-import { CHECK_FOR_UPDATES, UPDATE_AVAILABLE } from "./messages"
 
 const timeBetweenUpdateChecks = 30 * 60 * 1000
 let mainWindow: Electron.BrowserWindow | null = null

diff --git a/src/lib/anilist.ts b/src/lib/anilist.ts
@@ -34,6 +34,7 @@ export class Anilist {
         title: "AniList Login",
         darkTheme: true,
         backgroundColor: "#111",
+        webPreferences: { contextIsolation: false },
       })
 
       authWindow

diff --git a/src/lib/ffmpeg/download.ts → src/lib/ffmpeg.ts b/src/lib/ffmpeg/download.ts → src/lib/ffmpeg.ts
diff --git a/src/views/settings/settings.vue b/src/views/settings/settings.vue
@@ -514,7 +514,7 @@ export default class Settings extends Vue {
   public pathClick() {
     if (isNil(this.localFilesFolder)) return
 
-    shell.openItem(this.localFilesFolder)
+    shell.openPath(this.localFilesFolder)
   }
 
   public setMainListPlugin(plugin: string) {

diff --git a/yarn.lock b/yarn.lock
@@ -6799,10 +6799,10 @@ electron-util@0.14.2:
     electron-is-dev "^1.1.0"
     new-github-issue-url "^0.2.1"
 
-electron@8.3.1:
-  version "8.3.1"
-  resolved "https://registry.yarnpkg.com/electron/-/electron-8.3.1.tgz#79e98c4d5b8e7c09a8a811f1aa78903f0c692721"
-  integrity sha512-VZpgLVFyD2SwFDkO9rwUcNgrAMah+g38FEtALGxli8bRVTbcHl8bt21szfa0YUWpc6hWcaf6JdZjqDS5q73Bsg==
+electron@9.4.4:
+  version "9.4.4"
+  resolved "https://registry.yarnpkg.com/electron/-/electron-9.4.4.tgz#2a74a0655a74bd326216672c5ae6ed3a44451446"
+  integrity sha512-dcPlTrMWQu5xuSm6sYV42KK/BRIqh3erM8v/WtZqaDmG7pkCeJpvw26Dgbqhdt78XmqqGiN96giEe6A3S9vpAQ==
   dependencies:
     "@electron/get" "^1.0.1"
     "@types/node" "^12.0.12"