Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multithread lensfun vignetting correction #5549

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Multithread lensfun vignetting correction #5549

merged 2 commits into from
Dec 3, 2019

Conversation

heckflosse
Copy link
Collaborator

Processing time for a 24 MPixel file went down from ~230 to ~40 ms on my 8-core.

I tested for differences and races. Found none.
I also removed one Mutex because imho it's not needed.

@heckflosse heckflosse added the scope: performance Performance issues and improvements label Dec 2, 2019
@heckflosse heckflosse added this to the v5.8 milestone Dec 2, 2019
@heckflosse heckflosse self-assigned this Dec 2, 2019
Floessie
Floessie approved these changes Dec 3, 2019
View reviewed changes
Copy link
Collaborator

@Floessie Floessie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles and runs fine on Debian 10 i386 and PPC. I tried to crash it on AMD64 but failed. 👍

@heckflosse heckflosse merged commit 0044192 into dev Dec 3, 2019
@heckflosse heckflosse deleted the lensfun_vignetting_correction_speedup branch December 3, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Floessie Floessie Floessie approved these changes

Assignees

@heckflosse heckflosse

Labels
scope: performance Performance issues and improvements
Projects
None yet
Milestone
v5.8
Development

Successfully merging this pull request may close these issues.
2 participants
@heckflosse @Floessie