Allow Symfony 6 #1346
Merged
Allow Symfony 6 #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
approved these changes
Sep 14, 2021
No parameters are displayed in the stacktrace, so asserting Behat\Testwork\Call\Handler\RuntimeCallHandler->executeCall(...) fails
|
Thanks a lot, Hugo! 🎉 |
This was referenced Oct 18, 2021
This was referenced Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 6 will be released in 5 months, but I think it would be a nice thing to prepare Behat for Symfony 6.
I had to update a test, the stacktrace displayed when an exception is thrown does not contains parameters anymore. Changed
RuntimeCallHandler->executeCall(Object(Behat\Behat\Definition\Call\DefinitionCall))toRuntimeCallHandler->executeCall(Object(to fix that:WDYT?