Refactor transformations #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @param string $suiteName | ||
| * @param string $pattern | ||
| * @param string$language |
|
|
||
| use Behat\Behat\Transformation\Transformation; | ||
| use Behat\Testwork\Call\RuntimeCallee; | ||
|
|
||
| /** | ||
| * Transformation that is created and executed in the runtime. | ||
| * | ||
| * @deprecated Will be removed in 4.0. Use specific transformations instead |
There was a problem hiding this comment.
I suggest using the @trigger_error('...', E_USER_DEPRECATED) convention used by Symfony (which reminds me that someone wrote a Behat extension to collect deprecations, which I said I would review and I forgot to do it)
There was a problem hiding this comment.
btw, if you rename the class, deprecating it is useless: it is already a BC break. you would need to keep it in the Call namespace
|
I'll move |
everzet
force-pushed
the
refactoring/transformations
branch
from
23a5cc4
to
834e78c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts individual transformations from
RepositoryArgumentTransformerinto individual classes underBehat\Behat\Transformation\Transformationnamespace. This should make adding new transformations and fixing old ones a breeze.This PR is basis for upcoming transformation improvements in 3.2.