Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitespace is allowed in tags #213

Closed
ciaranmcnulty opened this issue Feb 4, 2021 · 0 comments
Closed

Whitespace is allowed in tags #213

ciaranmcnulty opened this issue Feb 4, 2021 · 0 comments
Labels
cucumber-parity

Comments

@ciaranmcnulty
Copy link
Contributor

We currently allow @foo bar baz as a single tag, but cucumber does not

Removing this line will produce a failing test
https://github.com/Behat/Gherkin/blob/master/tests/Behat/Gherkin/Cucumber/CompatibilityTest.php#L48
@ciaranmcnulty ciaranmcnulty mentioned this issue Feb 5, 2021
Merged
@andriokha andriokha mentioned this issue Nov 14, 2021
Closed
andriokha added a commit to andriokha/drupalextension that referenced this issue Nov 14, 2021
@andriokha
Avoid whitespace in tags jhedstrom#600
27e1482 
Since Gherkin 4.9.0 tags with whitespace are deprecated: use a comma as
an explicit OR operator.

See
- Behat/Gherkin#213
- Behat/Gherkin#215
- https://behat.org/en/latest/user_guide/context/hooks.html#tagged-hooks

Closes jhedstrom#600
@andriokha andriokha mentioned this issue Nov 14, 2021
Merged
Berdir pushed a commit to Berdir/drupalextension that referenced this issue Apr 24, 2022
@andriokha @Berdir
Avoid whitespace in tags jhedstrom#600
a04dd66 
Since Gherkin 4.9.0 tags with whitespace are deprecated: use a comma as
an explicit OR operator.

See
- Behat/Gherkin#213
- Behat/Gherkin#215
- https://behat.org/en/latest/user_guide/context/hooks.html#tagged-hooks

Closes jhedstrom#600
xurizaemon pushed a commit to xurizaemon/drupalextension that referenced this issue Nov 28, 2022
@andriokha @xurizaemon
Avoid whitespace in tags jhedstrom#600
e4f5a0a 
Since Gherkin 4.9.0 tags with whitespace are deprecated: use a comma as
an explicit OR operator.

See
- Behat/Gherkin#213
- Behat/Gherkin#215
- https://behat.org/en/latest/user_guide/context/hooks.html#tagged-hooks

Closes jhedstrom#600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cucumber-parity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ciaranmcnulty