threshold child count dynamically in parallel control node #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging fd4763c into e6f241c - view on LGTM.com new alerts:
|
zflat
force-pushed
the
parallel_all
branch
2 times, most recently
from
a36ca05
to
2e39c10
Compare
|
@facontidavide Could I please get a review of this pull request? |
|
thanks, it is a good change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modification to the
ParallelNodecontrol to allow negative success threshold and failure threshold values that act like the negative index in python arrays to count backwards from the child node count. This allows for thresholds to be dynamic so that additions or removals of child nodes in an XML file will not require an update to thresholds if the intention is to have threshold values based on the total number of children.