Fix incorrect registration of behavior trees containing faulty XML #438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where a behavior tree containing an invalid structure (for example, a BehaviorTree with less than one child or more than two children) could still be instantiated by the factory, even though the XML parser threw and exception when trying to load it. This was possible because adding a BehaviorTree's name to the list of available behavior trees occurred before the check for the validity of the BehaviorTree's XML.
tree_names
andtree_count
variables.Move XML parsing helper functions into an anonymous namespace so they can be used in more places.