Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<include> with ros_pkg does not work anymore with ROS 1 (in BehaviorTree.CPP version 3.8) #545

Closed
divbyzerofordummies opened this issue Apr 18, 2023 · 0 comments
Closed

<include> with ros_pkg does not work anymore with ROS 1 (in BehaviorTree.CPP version 3.8) #545

divbyzerofordummies opened this issue Apr 18, 2023 · 0 comments
Assignees
@facontidavide

Comments

@divbyzerofordummies
Copy link

Version BehaviorTree.CPP: 3.8

In xml_parsing.cpp, void XMLParser::Pimpl::loadDocImpl, the #ifdef clauses are incorrect since for USING_ROS, the variable ros_pkg_path is not used to update the file_path.

The include of other XML files is therefore performed relative to the current path and not the ROS package path.
divbyzerofordummies pushed a commit to divbyzerofordummies/BehaviorTree.CPP that referenced this issue Apr 18, 2023
@best4innio
Fix issue BehaviorTree#545
4b9aad9
@facontidavide facontidavide self-assigned this Apr 19, 2023
facontidavide added a commit that referenced this issue May 10, 2023
@facontidavide
Merge pull request #546 from divbyzerofordummies/fix_ROS_include
d25e5b9 
Fix issue #545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facontidavide facontidavide

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@facontidavide @divbyzerofordummies