depend only on libboost-coroutine(-dev) for v3.8 #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least on Ubuntu, boost-all-dev depends on openmpi, which depends on a fortran compiler and gcc. This is very heavy for Docker containers where only exec dependencies are really needed.
|
I might be Ok with this, but honestly there are so many packages in ROS that use boost that I doubt it won't be installed anyway |
|
In ROS 1 probably not, but in ROS 2 iron for us nav2_behavior_tree and therefore behaviortree_cpp is actually one of the few remaining ones. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on Ubuntu, boost-all-dev depends on openmpi, which depends on a fortran compiler and gcc. This is quite heavy for Docker containers where only exec dependencies are really needed.
Rosdep now has entries for finer-grained boost dependencies, so using those, a lot fewer packages will be installed.
Rough numbers ontop of
ros:iron-ros-core:I'm not 100% sure how this interacts with the .deb packaging process, but even using
would be quite an improvement.