Add PhoneCall and Texting component enums #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
soc/upgraders
branch
2 times, most recently
from
5f178db
to
2397937
Compare
BeksOmega
force-pushed
the
soc/upgraders
branch
2 times, most recently
from
52dd1cd
to
d049c2a
Compare
ewpatton
requested changes
Aug 17, 2020
appinventor/components/src/com/google/appinventor/components/runtime/PhoneCall.java
Outdated
Show resolved
Hide resolved
appinventor/components/src/com/google/appinventor/components/runtime/PhoneCall.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #6
Added EndedStatus and StartedStatus for the PhoneCall component. Added ReceivingState for the Texting component.
Testing
I had trouble testing this one because I couldn't get the PhoneCall events to fire (even on the released version of App Inventor). I also couldn't get the Texting events to fire on either version. I'm not sure if this is something I'm doing wrong, or it's a bug.
But the blocks do show up, and for the Texting component at least the values seem to be getting handled correctly.
Recommended Method for Review
Commit-Wise